[webkit-reviews] review granted: [Bug 26723] clientX, Y , screenX , Y always (0, 0) in dragstart event : [Attachment 31943] Fix: Make sure the m_mouseDown event is set correctly

Fri Jun 26 12:41:08 PDT 2009

Mark Rowe (bdash) <mrowe at apple.com> has granted Jessie Berlin
<jberlin at apple.com>'s request for review:
Bug 26723: clientX,Y , screenX , Y always (0, 0) in dragstart event
https://bugs.webkit.org/show_bug.cgi?id=26723

Attachment 31943: Fix: Make sure the m_mouseDown event is set correctly
https://bugs.webkit.org/attachment.cgi?id=31943&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebCore/page/EventHandler.cpp
> ===================================================================
> --- WebCore/page/EventHandler.cpp	(revision 45259)
> +++ WebCore/page/EventHandler.cpp	(working copy)
> @@ -354,6 +354,8 @@ bool EventHandler::handleMousePressEvent
>  
>      m_mouseDownWasSingleClickInSelection = false;
>  
> +    m_mouseDown = event.event();
> +
>      if (event.isOverWidget() && passWidgetMouseDownEventToWidget(event))
>	   return true;

You should remove the now-redundant assignment to m_mouseDown from
EventHandler::mouseDown in EventHandlerMac.mm.

> +    <body onload="Test.runTest()">
> +	   <h3>Test for <a
href='https://bugs.webkit.org/show_bug.cgi?id=26723'>WebKit bug 26723</a>:
clientX,Y , screenX , Y always (0, 0) in dragstart event</h3>
> +	   <div id="notDraggable" class="test">
> +	       DON'T BOTHER TRYING TO DRAG ME
> +	   </div>
> +	   <div id="alsoNotDraggable" class="test" style="display:
inline-block;">
> +	       DON'T BOTHER TRYING TO DRAG ME	 
> +	   </div>
> +	   <div id="draggable" class="test" style="display: inline-block;">
> +	       DRAG ME!
> +	   </div>
> +	   <div id="result"></div>
> +    </body>
> +</html>

What're the two non-draggable elements about?  They don't seem to be used in
the test. If they're not needed, it would make the test clearer if they weren't
present.

r=me