[webkit-reviews] review granted: [Bug 26661] Fullscreen button should be hidden when the backend doesn't support it. : [Attachment 31886] patch 1/2 - v4.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 26 11:14:50 PDT 2009


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26661: Fullscreen button should be hidden when the backend doesn't support
it.
https://bugs.webkit.org/show_bug.cgi?id=26661

Attachment 31886: patch 1/2 - v4.
https://bugs.webkit.org/attachment.cgi?id=31886&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +bool MediaControlFullscreenButtonElement::rendererIsNeeded(RenderStyle*
style)
> +{
> +    return m_mediaElement->supportsFullscreen() &&
HTMLInputElement::rendererIsNeeded(style);

Should just call up to the superclass here, not skip a generation.


More information about the webkit-reviews mailing list