[webkit-reviews] review denied: [Bug 20578] [CAIRO] pattern of a canvas-element changes after modifications on canvas-element : [Attachment 31764] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 26 03:25:46 PDT 2009


Eric Seidel <eric at webkit.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 20578: [CAIRO] pattern of a canvas-element changes after modifications on
canvas-element
https://bugs.webkit.org/show_bug.cgi?id=20578

Attachment 31764: Patch v2
https://bugs.webkit.org/attachment.cgi?id=31764&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think this should be broken into a "copySurface" static inline.  That
function should have a comment pointing to the discussion about how cairo is
lacking this call.

Otherwise this looks great.

I think it would be nice to fix the one nit about breaking this out into its
own function with a comment about how cairo doesn't provide this natively. 
Eventually cairo is likely to provide this, and when it does, we can replace
your copySurface function with a call to the native cairo call.


More information about the webkit-reviews mailing list