[webkit-reviews] review granted: [Bug 26740] bugzilla-tool post-diff needs to obsolete old patches before posting : [Attachment 31890] patch

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 26740: bugzilla-tool post-diff needs to obsolete old patches before posting
https://bugs.webkit.org/show_bug.cgi?id=26740

Attachment 31890: patch
https://bugs.webkit.org/attachment.cgi?id=31890&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> +	       log("Obsoleteting %s on bug %s" % (pluralize('old patch',
len(patches)), bug_id))

Obsoleting :)

> -
> -	       if str(review_status).find("review+") != -1:
> -		   reviewer = review_status.contents[0].split(':')[0] # name:\n
review+\n
> -		   reviewer_full_name =
self.full_name_from_bugzilla_name(reviewer)
> -		   attachment['reviewer'] = reviewer_full_name
> +	       attachment['is_obsolete'] = (element.has_key('isobsolete') and
element['isobsolete'] == "1")
> +	       attachment['is_patch'] = (element.has_key('ispatch') and
element['ispatch'] == "1")

I think without '== "1"' should be fine as well.

r=me.