[webkit-reviews] review granted: [Bug 26698] Combined LocalStorageArea and SessionStorageArea into StorageArea : [Attachment 31869] patch v3

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 26698: Combined LocalStorageArea and SessionStorageArea into StorageArea
https://bugs.webkit.org/show_bug.cgi?id=26698

Attachment 31869: patch v3
https://bugs.webkit.org/attachment.cgi?id=31869&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/storage/StorageArea.cpp
...
> +PassRefPtr<StorageArea> StorageArea::createLocalStorage(SecurityOrigin*
origin, PassRefPtr<StorageSyncManager> syncManager)
...
> +StorageArea::StorageArea(SecurityOrigin* origin,
PassRefPtr<StorageSyncManager> syncManager)
...
> +PassRefPtr<StorageArea> StorageArea::createSessionStorage(SecurityOrigin*
origin, Page* page)
...
> +PassRefPtr<StorageArea> StorageArea::copy(SecurityOrigin* origin, Page*
page)
...
> +StorageArea::StorageArea(SecurityOrigin* origin, Page* page,
PassRefPtr<StorageMap> storageMap)

stylistic nit: it is usually good to make the order of the methods in the .cpp
file match the
order in which the methods are declared in the .h file.  maybe you can fix this
up in a follow
up patch.

still, r=me