[webkit-reviews] review cancelled: [Bug 24187] RTL: tooltip does not get its directionality from its element's directionality : [Attachment 31868] patch w/o layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 25 11:54:10 PDT 2009


Xiaomei Ji <xji at chromium.org> has cancelled 's request for review:
Bug 24187: RTL: tooltip does not get its directionality from its element's
directionality
https://bugs.webkit.org/show_bug.cgi?id=24187

Attachment 31868: patch w/o layout test
https://bugs.webkit.org/attachment.cgi?id=31868&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
I am removing the review flag since this patch changes the signature of 
virtual void ChromeClient::setToolTip(const String&, TextDirection) = 0,
which requires all client uses this method to change and recompile.

I will upload another patch to keep the signature the same and added another
virtual API instead.


More information about the webkit-reviews mailing list