[webkit-reviews] review denied: [Bug 26659] Support hidding an control bar element from the Media element controller (display:none does not work for media control elements) : [Attachment 31817] patch v3.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26659: Support hidding an control bar element from the Media element
controller (display:none does not work for media control elements)
https://bugs.webkit.org/show_bug.cgi?id=26659

Attachment 31817: patch v3.
https://bugs.webkit.org/attachment.cgi?id=31817&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
Let's get rid of the m_isHidden on MediaControlInputElement, and a virtual
method shouldBeVisible() on MediaControlInputElement that you can override to
ask about fullscreen etc. updateStyle() will then need to handle the detach()
case. Also need to clean up update() vs. updateStyle().