[webkit-reviews] review requested: [Bug 26718] [Gtk] Add support for javascript windows for DRT : [Attachment 31854] Gtk DRT JS windows support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 25 05:03:21 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 26718: [Gtk] Add support for javascript windows for DRT
https://bugs.webkit.org/show_bug.cgi?id=26718

Attachment 31854: Gtk DRT JS windows support
https://bugs.webkit.org/attachment.cgi?id=31854&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
This patch adds a new property: javascript-can-open-windows and a new signal
close-web-view to tell the clients that the window will be closing soon. This
signal is also the other half of create-web-view which is already an API in
WebKitGtk.

These two features are needed to get JS windows support in Gtk DRT. I've also
unskip the tests that now run because of this (there's probably more but this
set will do for now).


More information about the webkit-reviews mailing list