[webkit-reviews] review denied: [Bug 25889] [GTK] scrollbar policy for main frame is not implementable : [Attachment 31111] report scrollbar policy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 25 04:35:01 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 25889: [GTK] scrollbar policy for main frame is not implementable
https://bugs.webkit.org/show_bug.cgi?id=25889

Attachment 31111: report scrollbar policy
https://bugs.webkit.org/attachment.cgi?id=31111&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
(In reply to comment #29)
> (In reply to comment #28)
> > I think you want to add _() to the properties names?
> > 
> 
> Yeah, I was planning to do that when committing, as well as the doc change
> suggested by Christian in #24. I just wanted to avoid uploading a new patch.
> You want me to do it?

Please update the patch with regards to Christian's and Holger's comments, +
update "Since".

Also, can we add a test for this (if we don't have one for it yet - layout,
unit tests)?

I'll r- this for now based on the these.


More information about the webkit-reviews mailing list