review requested: [Bug 26714] DumpRenderTree fails to link in debug_and_release on Mac : [Attachment 31836] 2009-06-25 Tor Arne Vestbø <tor.arne.vestbo at nokia.com>
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 25 01:19:04 PDT 2009
Tor Arne Vestbø <vestbo at webkit.org> has asked for review:
Bug 26714: DumpRenderTree fails to link in debug_and_release on Mac
https://bugs.webkit.org/show_bug.cgi?id=26714
Attachment 31836: 2009-06-25 Tor Arne Vestbø <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=31836&action=review
------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
Reviewed by NOBODY (OOPS!).
Use Q_ASSERT in Qt's DumpRenderTree instead of JSC's ASSERT
The WTFReportAssertionFailure function in JSC is not exported when
building QtWebKit in both debug and release on Mac, so DRT fails to
link.
We can revert this patch once the Qt port builds JSC as a separate
library, and we add the proper export macros to Assertions.cpp---
2 files changed, 20 insertions(+), 4 deletions(-)
More information about the webkit-reviews
mailing list