[webkit-reviews] review denied: [Bug 26703] bugzilla-tool apply-patches needs --local-commit and land-patches should support multiple bugs : [Attachment 31827] Support local commits during apply-patches

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 26703: bugzilla-tool apply-patches needs --local-commit and land-patches
should support multiple bugs
https://bugs.webkit.org/show_bug.cgi?id=26703

Attachment 31827: Support local commits during apply-patches
https://bugs.webkit.org/attachment.cgi?id=31827&action=review

------- Additional Comments from David Levin <levin at chromium.org>
My real concern is the commit message so r- for that.


> diff --git a/WebKitTools/Scripts/bugzilla-tool
b/WebKitTools/Scripts/bugzilla-tool
>	   for patch in patches:
>	       tool.scm().apply_patch(patch)
> +	       if options.local_commit:
> +		   tool.scm().commit_locally_with_message(patch['name'])

As discussed, the message given here doesn't seem like the right thing.


> diff --git a/WebKitTools/Scripts/modules/scm.py
b/WebKitTools/Scripts/modules/scm.py
> index e226962..7c9593f 100644
> --- a/WebKitTools/Scripts/modules/scm.py
> +++ b/WebKitTools/Scripts/modules/scm.py
> @@ -65,14 +65,14 @@ class SCM:
>	   output = process.communicate(input)[0].rstrip()
>	   exit_code = process.wait()
>	   if raise_on_failure and exit_code:
> -	       raise ScriptError("Failed to run " + command)
> +	       raise ScriptError("Failed to run \"%s\"	exit_code: %d  cwd: %s"
% (command, exit_code, cwd))

Consider:
	    raise ScriptError('Failed to run "%s"  exit_code: %d  cwd: %s' %
(command, exit_code, cwd))