[webkit-reviews] review granted: [Bug 26658] Split the Synching portion of LocalStorageArea into its own class : [Attachment 31731] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 24 16:51:54 PDT 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 26658: Split the Synching portion of LocalStorageArea into its own class
https://bugs.webkit.org/show_bug.cgi?id=26658

Attachment 31731: patch v1
https://bugs.webkit.org/attachment.cgi?id=31731&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +2009-06-23  Jeremy Orlow  <jorlow at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +

nit: please include a bug link.


> +	   * storage/StorageAreaSync.cpp: Copied from
WebCore/storage/LocalStorageArea.cpp.
> +	   (WebCore::StorageAreaSync::create):

nit: it is common practice to delete the list of methods for file copies since
they aren't that interesting to the reader of the ChangeLog.


Otherwise, R=me


More information about the webkit-reviews mailing list