[webkit-reviews] review requested: [Bug 26655] ResourceHandle infrastructure is needed to support loading out of an appcache : [Attachment 31813] Interceptor (rev2)

[bugzilla-daemon at webkit.org]

Michael Nordman <michaeln at google.com> has asked  for review:
Bug 26655: ResourceHandle infrastructure is needed to support loading out of an
appcache
https://bugs.webkit.org/show_bug.cgi?id=26655

Attachment 31813: Interceptor (rev2)
https://bugs.webkit.org/attachment.cgi?id=31813&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
Uploaded another stab it using the "other approach"... the wrapper class
* renamed existing ResourceHandle.h cpp --> PlatformResourceHandle.h cpp
* introduced new ResourceHandle.h cpp with same interface as existing class,
but
have it use the PlatformResourceHandle for everything
* bake ResourceHandleInterceptor usage into the new class

The good thing about this approach is that it only calls for entirely
mechanical
changes to the existing platorm specific ResourceHandle impls... simple class
name changes.

Still just looking for preliminary comments right now. An obvious thing thats
needed are test cases.

Incidentally, chrome has the moral equivalent, URLRequest::Interceptor, in
place for this already... http://codereview.chromium.org/67019... including a
decent set of test cases. I'll be looking to implement similar tests for this 
ResourceHandle Intercepor stuff.