[webkit-reviews] review granted: [Bug 26672] google.com/adplanner shows blank page instead of site details in "basic research' : [Attachment 31776] appease the colonies

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 26672: google.com/adplanner shows blank page instead of site details in
"basic research'
https://bugs.webkit.org/show_bug.cgi?id=26672

Attachment 31776: appease the colonies
https://bugs.webkit.org/attachment.cgi?id=31776&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   virtual bool isCommaNode() const { return true; }

This should be private. No one should ever call this function if they already
have a CommaNode* and making it private would detect that mistake.

I personally think we should fix this kind of thing by making *code generation*
iterative rather than preventing the tree from getting deep. It seems we still
can easily have problems in deeply nested cases of other types.

r=me