[webkit-reviews] review granted: [Bug 24735] Poor setDragImage support on Windows : [Attachment 31785] Adds the ability to set an element as the drag image on Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 24 09:45:54 PDT 2009


Adam Roben (aroben) <aroben at apple.com> has granted Jessie Berlin
<jberlin at apple.com>'s request for review:
Bug 24735: Poor setDragImage support on Windows
https://bugs.webkit.org/show_bug.cgi?id=24735

Attachment 31785: Adds the ability to set an element as the drag image on
Windows
https://bugs.webkit.org/attachment.cgi?id=31785&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>  DragImageRef ClipboardWin::createDragImage(IntPoint& loc) const
>  {
>      HBITMAP result = 0;
> -    //FIXME: Need to be able to draw element <rdar://problem/5015942>
>      if (m_dragImage) {
>	   result = createDragImageFromImage(m_dragImage->image());	   
>	   loc = m_dragLoc;
> +    } else if (m_dragImageElement) {
> +	   Node* node = dragImageElement();
> +	   result = node->document()->frame()->nodeImage(node);
> +	   loc = m_dragLoc;
>      }

It's strange to use m_dragImageElement on the first line, then
dragImageElement() on the second. I don't really have a preference, but using
m_dragImageElement consistently would match the code above more closely.

r=me


More information about the webkit-reviews mailing list