[webkit-reviews] review denied: [Bug 17052] Scrolling with arrow keys does not update cursor : [Attachment 31772] A proposed patch for this bug

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 17052: Scrolling with arrow keys does not update cursor
https://bugs.webkit.org/show_bug.cgi?id=17052

Attachment 31772: A proposed patch for this bug
https://bugs.webkit.org/attachment.cgi?id=31772&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Typo updateCurrentMousePoistions should be updateCurrentMousePositions

I'm also really unhappy with the the addition of multiple #if PLATFORM(WIN)
cases.	There is no explanation of why these should be windows only.
Sending a mouseMove event in response to a key board even t seems highly
suspect and i'd want tests for that behaviour, and confirmation that other
browsers do it
I don't think we should be refreshing the cursor on every key event if we can
avoid it -- in the general case we won't need to update, so updating every time
seems incorrect.

I would think a superior solution would be to update the mouse state if an
element that is currently under the mouse scrolls, but i think hyatt would be
the one to talk about that in general.