[webkit-reviews] review denied: [Bug 26577] Same warnings in yarr : [Attachment 31621] Revised patch based on Darin's feedback.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 26577: Same warnings in yarr
https://bugs.webkit.org/show_bug.cgi?id=26577

Attachment 31621: Revised patch based on Darin's feedback.
https://bugs.webkit.org/attachment.cgi?id=31621&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Compile fails:

    /Developer/usr/bin/distcc /Developer/usr/bin/gcc-4.2 -x c++ -arch i386
-fmessage-length=0 -pipe -Wno-trigraphs -fno-exceptions -fno-rtti
-fpascal-strings -fasm-blocks -O0 -Werror -Wnon-virtual-dtor -Wnewline-eof
-DHAVE_DTRACE=0 -DWEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST
-fstrict-aliasing -fvisibility-inlines-hidden -fno-threadsafe-statics
-mmacosx-version-min=10.5 -gdwarf-2
-I/Users/eseidel/Projects/build/JavaScriptCore.build/Debug/JavaScriptCore.build
/JavaScriptCore.hmap -Wall -Wextra -Wcast-align -Wcast-qual -Wchar-subscripts
-Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute
-Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef
-Wwrite-strings -Wshorten-64-to-32 -fpch-preprocess
-F/Users/eseidel/Projects/build/Debug
-I/Users/eseidel/Projects/build/Debug/include
-I/Users/eseidel/Projects/build/Debug/DerivedSources/JavaScriptCore -I. -Iicu
-I/Users/eseidel/Projects/build/JavaScriptCore.build/Debug/JavaScriptCore.build
/DerivedSources -include
/var/folders/zz/zzzivhrRnAmviuee++2Pvk+-4yw/-Caches-/com.apple.Xcode.72687/Shar
edPrecompiledHeaders/JavaScriptCorePrefix-ddaljcarndktnmciaabrbfjegeul/JavaScri
ptCorePrefix.h -c
/Users/eseidel/Projects/WebKit/JavaScriptCore/yarr/RegexCompiler.cpp -o
/Users/eseidel/Projects/build/JavaScriptCore.build/Debug/JavaScriptCore.build/O
bjects-normal/i386/RegexCompiler.o
cc1plus: warnings being treated as errors
/Users/eseidel/Projects/WebKit/JavaScriptCore/yarr/RegexCompiler.cpp: In member
function 'void JSC::Yarr::CharacterClassConstructor::putRange(UChar, UChar)':
/Users/eseidel/Projects/WebKit/JavaScriptCore/yarr/RegexCompiler.cpp:126:
warning: comparison between signed and unsigned integer expressions
/Users/eseidel/Projects/WebKit/JavaScriptCore/yarr/RegexCompiler.cpp:132:
warning: comparison between signed and unsigned integer expressions
distcc[38793] ERROR: compile
/Users/eseidel/Projects/WebKit/JavaScriptCore/yarr/RegexCompiler.cpp on
localhost failed