[webkit-reviews] review granted: [Bug 26375] VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp : [Attachment 31531] Proposed fix for 26375 (rev 3)

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Takeshi Yoshino
<tyoshino at google.com>'s request for review:
Bug 26375: VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in
WebKit/win/WebCoreLocalizedStrings.cpp
https://bugs.webkit.org/show_bug.cgi?id=26375

Attachment 31531: Proposed fix for 26375 (rev 3)
https://bugs.webkit.org/attachment.cgi?id=31531&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Wow!  Thank you for the awesome investigation.

Unfortunately the current patch doesn't seem to actually have the code change,
just a comment?

This is the only log message you need in the ChangeLog:
WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that
cannot be represented in the current code page (932). Save the file in Unicode
format to prevent data loss

The rest of the build output you can remove from the ChangeLog.

r- for lack of code change.  Otherwise I'd r+ this.  Thanks again for the
investigation!