[webkit-reviews] review denied: [Bug 25494] add PositionCreationFunctions.h in preparation for adding more position constructor functions : [Attachment 30847] Rename positionBeforeNode to positionInParentBeforeNode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 23 20:41:53 PDT 2009


Maciej Stachowiak <mjs at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 30847: Rename positionBeforeNode to positionInParentBeforeNode
https://bugs.webkit.org/attachment.cgi?id=30847&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
This still has "static inline" functions in headers, which I am pretty sure is
wrong. I think you missed this comment before.


More information about the webkit-reviews mailing list