[webkit-reviews] review requested: [Bug 26566] [V8] Upstream NPV8Object and V8NPUtils : [Attachment 31765] address eric's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 23 18:45:04 PDT 2009


Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 26566: [V8] Upstream NPV8Object and V8NPUtils
https://bugs.webkit.org/show_bug.cgi?id=26566

Attachment 31765: address eric's comments
https://bugs.webkit.org/attachment.cgi?id=31765&action=review

------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
I tried to address all of Eric's comments.

I couldn't use a PassOwnPtr however because the delete is an array delete. 
Silly C++ and its asymetric deletes. :-/

I also made a few attempts at cleaning up the code organization + factoring out
common parts, but ultimately failed at all of it.  There's too much stuff going
where error handling and object construction are interwoven. :(


More information about the webkit-reviews mailing list