[webkit-reviews] review granted: [Bug 26666] bugzilla-tool continues execution even if subcommands fail : [Attachment 31760] Make SCM.run_command smarter and use it more

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 26666: bugzilla-tool continues execution even if subcommands fail
https://bugs.webkit.org/show_bug.cgi?id=26666

Attachment 31760: Make SCM.run_command smarter and use it more
https://bugs.webkit.org/attachment.cgi?id=31760&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Only one comment:

> diff --git a/WebKitTools/Scripts/modules/scm.py
b/WebKitTools/Scripts/modules/scm.py
> +    def run_command(command, cwd=None, input=None, raise_on_failure=True,
return_exit_code=False):
> +	   stdin = subprocess.PIPE if input else None
> +	   process = subprocess.Popen(command, stdout=subprocess.PIPE,
stdin=stdin, shell=True, cwd=cwd)
> +	   output = process.communicate(input)[0].rstrip()
> +	   exit_code = process.wait()
> +	   if raise_on_failure and exit_code != 0:

Use:
	if raise_on_failure and exit_code: