[webkit-reviews] review denied: [Bug 26620] Haiku WebKit port : [Attachment 31669] Modifications on WebKit source code to allow Haiku port. (including ChangeLogs)

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 31669: Modifications on WebKit source code to allow Haiku port.
(including ChangeLogs)
https://bugs.webkit.org/attachment.cgi?id=31669&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
We should have a guidelines for starting a new port document.  And one of those
guidelines should be about setting up a buildbot after getting JavaScriptCore
compiling. ;)

Tab:
+		PlatformMenuDescription m_platformDescription;

Tab:
+	typedef BCursor* PlatformCursorHandle;

I believe the webkit style is FIXME:
+    // RJL TODO: May not need this, what is below may be fine

I'm surprised HAIKU needs its own notImplemented()... maybe all ports have
their own...

Are you really intending to copy the BPoint here?
+	 PlatformMouseEvent(BPoint where, BPoint screenPoint);

Tab:
+	BMenu* m_menu;

Tab:
+		pattern getHaikuStrokeStyle();

I think this is OK.  It's sad to add all these #ifdefs... but that's the state
of our porting infrastructure.

I would strongly encourage you to introduce yourself on webkit-dev along with
your intent.

It's not very interesting to have someone come and get WebKit building on Haiku
only to disappear 2 months later when GSoC is over.  Not saying you would, but
that's a possibility obviously. :)

It's important for new ports to have buildbots as well as maintainers active in
the community.	I think starting with some introductions on webkit-dev and
appearing in #webkit (if you aren't already) will help alleviate fears of
port-abandonment.

r- for the nits, and because not having ever met you or heard of Haiku before,
I'm not sure I won't have to rip out this code 2 weeks from now when Haiku
disappears. ;)	Lets talk on webkit-dev or #webkit.