[webkit-reviews] review granted: [Bug 26279] REGRESSION: typing in gmail pegs CPU : [Attachment 31755] Now with update layout, test rebaselines and correct ChangeLogs.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 23 16:19:43 PDT 2009


mitz at webkit.org has granted Ojan Vafai <ojan at chromium.org>'s request for
review:
Bug 26279: REGRESSION: typing in gmail pegs CPU
https://bugs.webkit.org/show_bug.cgi?id=26279

Attachment 31755: Now with update layout, test rebaselines and correct
ChangeLogs.
https://bugs.webkit.org/attachment.cgi?id=31755&action=review

------- Additional Comments from mitz at webkit.org
> +	   RefPtr<RenderStyle> style = m_node->computedStyle();

You should change this to a plain pointer, since computedStyle() returns a
pointer and you don’t do anything that could result in the style being
deref()ed. I think you have commit access, so you don’t need to post an updated
patch :)


More information about the webkit-reviews mailing list