[webkit-reviews] review denied: [Bug 25891] _NPN_HasMethod is too liberal in declaring methods : [Attachment 30646] Test Case + SourceCode change + hopefully better ChangeLog entry

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 25891: _NPN_HasMethod is too liberal in declaring methods
https://bugs.webkit.org/show_bug.cgi?id=25891

Attachment 30646: Test Case + SourceCode change + hopefully better ChangeLog
entry
https://bugs.webkit.org/attachment.cgi?id=30646&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Fails to build:

Ld /Users/eseidel/Projects/build/Debug/WebCore.framework/Versions/A/WebCore
normal i386
    cd /Users/eseidel/Projects/WebKit/WebCore
    setenv MACOSX_DEPLOYMENT_TARGET 10.5
    /Developer/usr/bin/g++-4.2 -arch i386 -dynamiclib
-L/Users/eseidel/Projects/build/Debug -F/Users/eseidel/Projects/build/Debug
-F/System/Library/Frameworks/Carbon.framework/Frameworks
-F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -filelist
/Users/eseidel/Projects/build/WebCore.build/Debug/WebCore.build/Objects-normal/
i386/WebCore.LinkFileList -Wl,--no-demangle -exported_symbols_list
/Users/eseidel/Projects/build/Debug/DerivedSources/WebCore/WebCore.exp
-install_name
/Users/eseidel/Projects/build/Debug/WebCore.framework/Versions/A/WebCore
-mmacosx-version-min=10.5 -lWebCoreSQLite3 -lobjc -sub_library libobjc
-umbrella WebKit -framework ApplicationServices -framework Carbon -framework
Cocoa -framework JavaScriptCore -framework QuartzCore -framework
SystemConfiguration -licucore -lobjc -lxml2 -Wl,-single_module
-compatibility_version 1 -current_version 531.0 -o
/Users/eseidel/Projects/build/Debug/WebCore.framework/Versions/A/WebCore
Undefined symbols:
  "__ZN3JSC16jsIsFunctionTypeENS_7JSValueE", referenced from:
      __NPN_HasMethod in NP_jsobject.o
ld: symbol(s) not found