[webkit-reviews] review requested: [Bug 26655] ResourceHandle infrastructure is needed to support loading out of an appcache : [Attachment 31738] Interceptor (rev1)

[bugzilla-daemon at webkit.org]

Michael Nordman <michaeln at google.com> has asked  for review:
Bug 26655: ResourceHandle infrastructure is needed to support loading out of an
appcache
https://bugs.webkit.org/show_bug.cgi?id=26655

Attachment 31738: Interceptor (rev1)
https://bugs.webkit.org/attachment.cgi?id=31738&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
Looking for some preliminary feedback on this new piece of webcore resource
handle
infrastructure.

These changes allow an 'interceptor' to hijack ResourceHandle requests and to
provide response data instead of actually going to the network.

The approach taken in this preliminary patch ripples into the platform
specific resourcehandleXXX.cpp files more than i would like. Its doable, just
very platform specific.

Another approach would be to introduce a new ResourceHandle class into the
hierarchy that 'wraps' the existing class. Something like...
* rename existing ResourceHandle.h cpp --> PlatformResourceHandle.h cpp
* introduce new ResourceHandle.h cpp with same interface as existing class, but

have it use ResourceHandleInterceptorHost  and PlatformResourceHandle for
everything under the covers. 

I'm preparing another patch with that hoist usage of the
ResourceHandleInterceptorHost into a new wrapper class as described above.