[webkit-reviews] review denied: [Bug 26611] Implement currentThreadStackBase on WinCE : [Attachment 31682] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 23 07:43:16 PDT 2009


Adam Treat <treat at kde.org> has denied Joe Mason <joe.mason at torchmobile.com>'s
request for review:
Bug 26611: Implement currentThreadStackBase on WinCE
https://bugs.webkit.org/show_bug.cgi?id=26611

Attachment 31682: updated patch
https://bugs.webkit.org/attachment.cgi?id=31682&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Much better style, but still a few nits:

> +inline bool isPageWritable(void* page)
> +{
> +    MEMORY_BASIC_INFORMATION buf;
> +    DWORD result = VirtualQuery(page, &buf, sizeof(buf));

s/buf/buffer/

> +    if (!pageSize) {
> +	   SYSTEM_INFO sysInfo;

s/sysInfo/systemInfo/

> +    register char* curPage = (char*)((DWORD)thisFrame & ~(pageSize - 1));

s/curPage/currentPage/


More information about the webkit-reviews mailing list