[webkit-reviews] review granted: [Bug 26537] Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists : [Attachment 31703] Proposed fix for 26537 (rev 5)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 23 01:11:45 PDT 2009
Mark Rowe (bdash) <mrowe at apple.com> has granted Takeshi Yoshino
<tyoshino at google.com>'s request for review:
Bug 26537: Builds from command-line fail if custom build product directory is
set and ~/Library/Preferences/xcodebuild.plist exists
https://bugs.webkit.org/show_bug.cgi?id=26537
Attachment 31703: Proposed fix for 26537 (rev 5)
https://bugs.webkit.org/attachment.cgi?id=31703&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
This looks fine to me. Lines in the ChangeLog and containing comments appear
to be wrapped at a very narrow width, making them hard to read. Whomever lands
the patch may want to reflow them at a more reasonable length.
More information about the webkit-reviews
mailing list