[webkit-reviews] review denied: [Bug 24300] Add CSSKeepVisitedLinksPrivate option to WebCore : [Attachment 31664] Updated patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied robert <robert at roberthogan.net>'s
request for review:
Bug 24300: Add CSSKeepVisitedLinksPrivate option to WebCore
https://bugs.webkit.org/show_bug.cgi?id=24300

Attachment 31664: Updated patch
https://bugs.webkit.org/attachment.cgi?id=31664&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
> +    Settings* settings = m_document->settings();
> +    if (!settings || settings->cssIgnoreVisitedLinks())
> +	   m_IgnoreVisitedLinks = true;

This should default to false if we can't find settings.

> +++ b/WebCore/manual-tests/css-ignore-visited-links.html

This should be a LayoutTest instead of a manual test.  See something like
xssAuditor to see how to test non-default settings in LayoutTests.