[webkit-reviews] review requested: [Bug 26328] Changing href attribute of svg images does not work when changing display attribute as well : [Attachment 31666] Back to fixing SVGImageElement::svgAttributeChanged

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 26328: Changing href attribute of svg images does not work when changing
display attribute as well
https://bugs.webkit.org/show_bug.cgi?id=26328

Attachment 31666: Back to fixing SVGImageElement::svgAttributeChanged
https://bugs.webkit.org/attachment.cgi?id=31666&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
These changes were made:

- I went back to the original fix. Since svgAttributeChanged is there for SVG
and parseMappedAttribute is not called for the JS bindings, I tried to fix up
SVGImageElement::svgAttributeChanged. Basically the xlink:href handling is
singled out first and done independent of renderer() being there or not. The
rest is as before, I hope the code is more readable than in the first patch. I
guess in the long run svgAttributeChanged should go (is there a bug for that?).

- I added a test for the href.baseValue setting alternative, which does not end
up in parseMappedAttribute.
- I updated the ChangeLogs because it also fixes bug 26392.
Cheers,

Rob.