[webkit-reviews] review granted: [Bug 26612] Notify of profile start in console : [Attachment 31656] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kevin McCullough
<kmccullough at apple.com>'s request for review:
Bug 26612: Notify of profile start in console
https://bugs.webkit.org/show_bug.cgi?id=26612

Attachment 31656: proposed patch
https://bugs.webkit.org/attachment.cgi?id=31656&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    void addProfileMessageToConsole(PassRefPtr<JSC::Profile> prpProfile,
unsigned lineNumber, const JSC::UString& sourceURL);
> +    void addProfileFinishedMessageToConsole(PassRefPtr<JSC::Profile>
prpProfile, unsigned lineNumber, const JSC::UString& sourceURL);

Should omit the name prpProfile here.

>      void addScriptProfile(JSC::Profile* profile);

And the name profile here.

>      const ProfilesArray& profiles() const { return m_profiles; }
>  
> +		   // The title is used in the console message announcing that
a profile has started so it get's

No apostrophe needed in gets.

r=me