[webkit-reviews] review granted: [Bug 26607] Implement IDL interface for datagrid rows : [Attachment 31650] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 26607: Implement IDL interface for datagrid rows
https://bugs.webkit.org/show_bug.cgi?id=26607

Attachment 31650: Patch
https://bugs.webkit.org/attachment.cgi?id=31650&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 44935)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,38 @@
> +2009-06-22  David Hyatt  <hyatt at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   WARNING: NO TEST CASES ADDED OR CHANGED


Some changelogy goodness please.


> +
> +#ifndef HTMLDataGridRowElement_h
> +#define HTMLDataGridRowElement_h
> +
> +#include "HTMLElement.h"
> +
> +namespace WebCore {
> +
> +class HTMLDataGridRowElement : public HTMLElement
> +{

{ should go on the previous line.

> +public:
> +    HTMLDataGridRowElement(const QualifiedName&, Document*);
> +
> +    virtual int tagPriority() const { return 2; } // Same as <option>s.
> +    
> +    bool selected() const;
> +    void setSelected(bool);
> +    
> +    bool focused() const;
> +    void setFocused(bool);
> +};
> +
> +} //namespace

should be // namespace WebCore

> +
> +#endif

We like to add #endif // HTMLDataGridRowElement_h

r=me with these cleanups.