[webkit-reviews] review denied: [Bug 26537] Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists : [Attachment 31638] Proposed fix for 26537 (rev 3)

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied 's request for review:
Bug 26537: Builds from command-line fail if custom build product directory is
set and ~/Library/Preferences/xcodebuild.plist exists
https://bugs.webkit.org/show_bug.cgi?id=26537

Attachment 31638: Proposed fix for 26537 (rev 3)
https://bugs.webkit.org/attachment.cgi?id=31638&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
This logic should go in webkitdirs.pm, near where we determine whether we need
to add any custom options to xcodebuild in relation to the build product
directory.  That code is also used by the Makefiles, so it would be good to
have the workaround affect both build-webkit and the Makefiles.  I also think
that removing the file silently if it exists is a better option, as we're just
asking the user to do something we can trivially do ourselves.	In addition,
it'd be great if you could update the comment to refer to the Radar number I
mentioned, so that in the future we can quickly determine why the workaround
exists and if it is still needed.  Something like the following should suffice:


   # The presence of ~/Library/Preferences/xcodebuild.plist can prevent
xcodebuild from respecting global settings such as a custom build products
directory (<rdar://problem/5585899>).