[webkit-reviews] review denied: [Bug 26594] JSC needs to support Date.toISOString : [Attachment 31628] Updated patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Oliver Hunt <oliver at apple.com>'s request
for review:
Bug 26594: JSC needs to support Date.toISOString
https://bugs.webkit.org/show_bug.cgi?id=26594

Attachment 31628: Updated patch
https://bugs.webkit.org/attachment.cgi?id=31628&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +    
> +    const bool utc = true;
> +    
> +    DateInstance* thisDateObj = asDateInstance(thisValue); 
> +    double milli = thisDateObj->internalNumber();
> +    if (isnan(milli))
> +	   return jsNontrivialString(exec, "Invalid Date");

According to
http://wiki.ecmascript.org/lib/exe/fetch.php?id=es3.1%3Aes3.1_proposal_working_
draft&cache=cache&media=es3.1:es5_candidate_errata_june_17.pdf, we should
throwing a RangeError for non-finite values.

> +    
> +    GregorianDateTime t;
> +    thisDateObj->msToGregorianDateTime(milli, true, t);

I believe the intent of the utc constant is to use it here instead of passing
true.


r- for the isnan bit.