[webkit-reviews] review granted: [Bug 26587] Support JSON.parse : [Attachment 31623] Address rest of darin's comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jun 21 15:57:22 PDT 2009
Cameron Zwarich (cpst) <zwarich at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 26587: Support JSON.parse
https://bugs.webkit.org/show_bug.cgi?id=26587
Attachment 31623: Address rest of darin's comments
https://bugs.webkit.org/attachment.cgi?id=31623&action=review
------- Additional Comments from Cameron Zwarich (cpst) <zwarich at apple.com>
You still have instances of
token.end = m_ptr += 5;
but you say you have fixed them locally. Now that you have removed the braces,
you should probably decide on a consistent style for whether or not there are
blank lines after the case statements inside of a switch. Other than that,
r=me.
More information about the webkit-reviews
mailing list