[webkit-reviews] review requested: [Bug 26328] Changing href attribute of svg images does not work when changing display attribute as well : [Attachment 31598] Different approach
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 20 12:44:58 PDT 2009
Rob Buis <rwlbuis at gmail.com> has asked for review:
Bug 26328: Changing href attribute of svg images does not work when changing
display attribute as well
https://bugs.webkit.org/show_bug.cgi?id=26328
Attachment 31598: Different approach
https://bugs.webkit.org/attachment.cgi?id=31598&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
I think this approach is clearer, the image loading is part of the general
attribute change notification and
does not depend on the renderer being there. If any svg attribute changes still
a setNeedsLayout is called, when there is a renderer. HTMLImageElement also
loads image on src changes in parseMappedAttribute.
Cheers,
Rob.
More information about the webkit-reviews
mailing list