[webkit-reviews] review cancelled: [Bug 26474] WML Card Title does not get displayed on GtkLauncher : [Attachment 31540] Updated Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 20 08:16:18 PDT 2009
Nikolas Zimmermann <zimmermann at kde.org> has cancelled Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 26474: WML Card Title does not get displayed on GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=26474
Attachment 31540: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=31540&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Looks good except the const_cast. Just make the
parseValueSubstitutingVariableReferences & parseValueForbidding... functions
const. They're not modifying any member variables and they are non-const by
mistake. Can you upload a new patch?
As you don't have commit access I'm going to clear the review flag until a new
patch has been uploaded. Going to commit that patch then.
More information about the webkit-reviews
mailing list