[webkit-reviews] review granted: [Bug 26409] [GTK] Glitches in new progress/load-status system : [Attachment 31594] Initial test case for loading

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 20 05:45:45 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 26409: [GTK] Glitches in new progress/load-status system
https://bugs.webkit.org/show_bug.cgi?id=26409

Attachment 31594: Initial test case for loading
https://bugs.webkit.org/attachment.cgi?id=31594&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> index 802a56b..34d5ced 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,11 @@
> +2009-06-20  Gustavo Noronha Silva  <gns at gnome.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Initial test case for loading.

Need to be more descriptive here.

> +static void
> +load_finished_cb(WebKitWebView* web_view, WebKitWebFrame* web_frame,
gpointer data)
> +{

Please put this in one line to match the other tests.

> +    return g_test_run ();

remove spaces.

r=me with these changes.


More information about the webkit-reviews mailing list