[webkit-reviews] review denied: [Bug 26567] [V8] Upstream V8 bindings code generator. : [Attachment 31586] Upstream V8 code generator, v1.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 19 22:33:39 PDT 2009


Sam Weinig <sam at webkit.org> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 26567: [V8] Upstream V8 bindings code generator.
https://bugs.webkit.org/show_bug.cgi?id=26567

Attachment 31586: Upstream V8 code generator, v1.
https://bugs.webkit.org/attachment.cgi?id=31586&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
r-.  There a couple of style issues that need to be taken care of such as 2
space indentation instead of 4 and commented out code.	I would also like an
explanation as to why the parent traversal stuff is necessary for v8 and not
JSC.


More information about the webkit-reviews mailing list