[webkit-reviews] review requested: [Bug 26561] Remove memcpy from ScriptSourceCode::source() : [Attachment 31574] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 19 16:44:10 PDT 2009


Adam Barth <abarth at webkit.org> has asked  for review:
Bug 26561: Remove memcpy from ScriptSourceCode::source()
https://bugs.webkit.org/show_bug.cgi?id=26561

Attachment 31574: patch
https://bugs.webkit.org/attachment.cgi?id=31574&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Notice that the string is kept alive anyway because the
ScriptSourceCode holds a JSC::SourceCode which holds a RefPtr<SourceProvider>
which holds String m_source (via StringSourceProvider : public
JSC::SourceProvider).


More information about the webkit-reviews mailing list