[webkit-reviews] review granted: [Bug 25916] WebKit should expose files from the pasteboard in drop events : [Attachment 31064] Updated patch to not break other builds.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 19 11:57:47 PDT 2009
Maciej Stachowiak <mjs at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 25916: WebKit should expose files from the pasteboard in drop events
https://bugs.webkit.org/show_bug.cgi?id=25916
Attachment 31064: Updated patch to not break other builds.
https://bugs.webkit.org/attachment.cgi?id=31064&action=review
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I'm going to say r=me with the following caveats:
1) Please file follow-up bugs for platforms that don't implement the back end
for this yet, at least for ports that have a public buildbot.
2) I think for platforms that don't support file drop yet, it might be better
to avoid having a "files" property at all on the Clipboard object, instead of
having the property and always returning null. So I think it would be good to
give the feature an ENABLE define.
More information about the webkit-reviews
mailing list