[webkit-reviews] review denied: [Bug 26552] JS bindings for HTMLAudioElement : [Attachment 31553] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 19 11:43:09 PDT 2009
Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Kyle Prete
<kylep at chromium.org>'s request for review:
Bug 26552: JS bindings for HTMLAudioElement
https://bugs.webkit.org/show_bug.cgi?id=26552
Attachment 31553: Patch
https://bugs.webkit.org/attachment.cgi?id=31553&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Need a ChangeLog entry.
> + if (args.Length() > 0) {
> + audio->setSrc(toWebCoreString(args[0]));
> + }
No braces for one-liners.
More information about the webkit-reviews
mailing list