[webkit-reviews] review granted: [Bug 26532] Native functions do not correctly unlink from optimised callsites when they're collected : [Attachment 31533] Fixeration

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 26532: Native functions do not correctly unlink from optimised callsites
when they're collected
https://bugs.webkit.org/show_bug.cgi?id=26532

Attachment 31533: Fixeration
https://bugs.webkit.org/attachment.cgi?id=31533&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Please to be adding ASSERTs to check code type enum is sizeof(int32_t), and add
ASSERTSs to cti_op_call_JSFunction & the arity check to the function is not a
host function.

Also, in the ChangeLog you say 'Reviewed by NOBODY (OOPS!).', this should read
'Reviewed by Gavin "Viceroy of Venezuela" Barraclough.'.

r+.
G.