[webkit-reviews] review denied: [Bug 26328] Changing href attribute of svg images does not work when changing display attribute as well : [Attachment 31257] Fixed testcases

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 26328: Changing href attribute of svg images does not work when changing
display attribute as well
https://bugs.webkit.org/show_bug.cgi?id=26328

Attachment 31257: Fixed testcases
https://bugs.webkit.org/attachment.cgi?id=31257&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't understand this clause:
 95	if (isURIAttribute)
 96	    m_imageLoader.updateFromElementIgnoringPreviousError();
 97	else if (!renderer())
 98	    return;

Why only return when ! isURIAttribute && !renderer()?  That seems wrong, given
all the other code below.

How does HTML handle this case?  This patch doesn't seem right.