[webkit-reviews] review granted: [Bug 26103] [GTK] Remove gtk/cairo/pango/freetype/fontconfig includes from the header files in WebCore : [Attachment 30814] The patch...

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 26103: [GTK] Remove gtk/cairo/pango/freetype/fontconfig includes from the
header files in WebCore
https://bugs.webkit.org/show_bug.cgi?id=26103

Attachment 30814: The patch...
https://bugs.webkit.org/attachment.cgi?id=30814&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks fine to me.	Why though?  I assume for compile performance?

This comment should reference the COMPILE_ASSERT:
+// This is in fact a cairo_glyph_t make sure this keeps matching

I don't really believe the numbers you posted.	The change was small (seconds).
 Did you run the numbers multiple times and confirm that your numbers are
consistent?

I'm really just gonna trust you on this one.