[webkit-reviews] review granted: [Bug 26448] Need to optimize MessagePort GC for same-thread case : [Attachment 31521] Revised patch per review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 17:38:08 PDT 2009


David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26448: Need to optimize MessagePort GC for same-thread case
https://bugs.webkit.org/show_bug.cgi?id=26448

Attachment 31521: Revised patch per review comments
https://bugs.webkit.org/attachment.cgi?id=31521&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/LayoutTests/fast/events/message-channel-gc-4.html-disabled
b/LayoutTests/fast/events/message-channel-gc-4.html-disabled
> +    channel2.port2.postMessage("", channel.port2);
> +    channel2.port2.onmessage = channel2.port1.onmessage = function(evt) {
> +	  evt.messagePort.onmessage = function(event) {
This should be indented by one more space.  (The alignment of things just
looked funny when I was reviewing it.)


I'll fix this when landing.


More information about the webkit-reviews mailing list