[webkit-reviews] review denied: [Bug 26460] Cross-platform ICO decoder should return all icons in file as separate frames, sorted by decreasing quality : [Attachment 31519] part two
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 18 17:34:48 PDT 2009
Eric Seidel <eric at webkit.org> has denied Peter Kasting <pkasting at google.com>'s
request for review:
Bug 26460: Cross-platform ICO decoder should return all icons in file as
separate frames, sorted by decreasing quality
https://bugs.webkit.org/show_bug.cgi?id=26460
Attachment 31519: part two
https://bugs.webkit.org/attachment.cgi?id=31519&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't think the line wraping is really worth it. But OK.
You were going to clean up the:
299 m_infoHeader.biClrUsed = readUint32(data, m_decodedOffset + 32);
stuff, and I'll look in more detail in a second pass. This is a big big to page
into my brain all at once. :)
More information about the webkit-reviews
mailing list