[webkit-reviews] review denied: [Bug 26502] [Chromium] Use WebCore::multipleFileUploadText() : [Attachment 31470] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 15:52:48 PDT 2009


David Levin <levin at chromium.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 26502: [Chromium] Use WebCore::multipleFileUploadText()
https://bugs.webkit.org/show_bug.cgi?id=26502

Attachment 31470: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=31470&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> Index: WebCore/ChangeLog
> +2009-06-17  Kent Tamura  <tkent at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Use WebCore::multipleFileUploadText() in Chromium.
> +	   <https://bugs.webkit.org/show_bug.cgi?id=26502>
> +

Ideally you would have something about why you are doing the change here?
What does the change accomplish?  (You have this in the bug.)

This change looks good but the changelog needs to be improved, so r- until that
is fixed.  With a better change log, I'd happily give it an r+.


More information about the webkit-reviews mailing list