[webkit-reviews] review denied: [Bug 17820] fast/js/date-DST-time-cusps.html and fast/js/date-big-setdate.html fail when not in PST/PDT time zone : [Attachment 31315] Yet another patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 17820: fast/js/date-DST-time-cusps.html and fast/js/date-big-setdate.html
fail when not in PST/PDT time zone
https://bugs.webkit.org/show_bug.cgi?id=17820

Attachment 31315: Yet another patch v1
https://bugs.webkit.org/attachment.cgi?id=31315&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +	   Skip layout tests for DST if the test runs not in PDT.

If my understanding is correct, PDT is daylight time, so these tests won't run
anywhere for 6 months each year. What does tzname return in California in
winter - should we perhaps permit PST, as well?

+	 { "inTimezonePDT", inTimezonePDTCallback, kJSPropertyAttributeReadOnly
| kJSPropertyAttributeDontDelete },

I think that you could get time zone name from Javascript - e.g. (new
Date).toString() returns "Thu Jun 18 2009 23:08:56 GMT+0400 (MSD)" for me. The
code for formatting dates is in formatTime() in DateConversion.cpp. Even if
it's necessary to add a method to DumpRenderTree, I'd make it return the time
zone name, not a boolean.