[webkit-reviews] review denied: [Bug 26474] WML Card Title does not get displayed on GtkLauncher : [Attachment 31404] Patch to add title attribute to card element

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied wajahat
<wajahatmeister at gmail.com>'s request for review:
Bug 26474: WML Card Title does not get displayed on GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=26474

Attachment 31404: Patch to add title attribute to card element
https://bugs.webkit.org/attachment.cgi?id=31404&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Hi Wajat,

thanks for the patch. Good that you spotted it, though I'd suggest a better
implementation of that.
WMLCardElement already provides a virtual-function "String title() const"
through the Element parent class.

So all you'd need to do is implement WMLCardElement::title() and have it return
"parseValueSub...(getAttribute(titleAttr...". See HTMLElement::title() for
comparision.
This way we save memory. Glad if you could upload a new patch.

Niko