[webkit-reviews] review denied: [Bug 25689] [Qt] Implement SearchPopupMenuQt : [Attachment 30606] Implementation for Qt using QSettings and QWebSettings with ChangeLog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 18 10:09:35 PDT 2009
Adam Treat <treat at kde.org> has denied Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 25689: [Qt] Implement SearchPopupMenuQt
https://bugs.webkit.org/show_bug.cgi?id=25689
Attachment 30606: Implementation for Qt using QSettings and QWebSettings with
ChangeLog
https://bugs.webkit.org/attachment.cgi?id=30606&action=review
------- Additional Comments from Adam Treat <treat at kde.org>
> + past search queries should be used for search fields. The search
queries will be
> + store with QSettings, for this to work make sure to call
Minor nit, but that should be 'stored' I believe.
> void SearchPopupMenuDelegate::saveRecentSearches(const AtomicString& name,
const Vector<String>& searchItems, Document*)
> {
> + if (name.isEmpty())
> + return;
> +
> + // put into the QStringList
> + QStringList urls;
> + for (int i = 0; i < searchItems.size(); ++i)
> + urls.append(searchItems[i]);
Shouldn't we have a maximum number of entries here?
Adam
More information about the webkit-reviews
mailing list